Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel feature with tracing functionality only #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LikhithST
Copy link

as suggested in pull request #97 this PR contains only the tracing functionality without the context transfer between clients and the databroker

@SebastianSchildt
Copy link
Contributor

@lukasmittag or @argerus please check if this is acceptable/non-invasive enough and if so approve. Would be nice to have basic OTEL support (we can still think about how to do the context transfer "nicer" in a follow up PR)

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 55.31915% with 42 lines in your changes missing coverage. Please review.

Project coverage is 59.01%. Comparing base (2159d18) to head (a4d4955).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
databroker/src/lib.rs 0.00% 23 Missing ⚠️
databroker/src/open_telemetry.rs 0.00% 16 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/val.rs 81.81% 2 Missing ⚠️
databroker/src/grpc/kuksa_val_v1/conversions.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   59.49%   59.01%   -0.48%     
==========================================
  Files          33       34       +1     
  Lines       16070    15048    -1022     
==========================================
- Hits         9561     8881     -680     
+ Misses       6509     6167     -342     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianSchildt
Copy link
Contributor

@LikhithST some minor mechanical linting issues: cargo fmt or clippy not happy, missing license identifier in otel.rs and some newline issue that can be fixed with the setting up pre-commit locally as described here https://github.com/eclipse-kuksa/kuksa-databroker/blob/main/CONTRIBUTING.md#pre-commit-set-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants